Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh: add enableSyntaxHighlighting option #2144

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

davegallant
Copy link
Contributor

@davegallant davegallant commented Jun 27, 2021

Description

Adds a simple way to enable syntax highlighting for zsh using https://github.com/zsh-users/zsh-syntax-highlighting

This was brought up in #1321.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@davegallant davegallant requested a review from rycee as a code owner June 27, 2021 00:52
@davegallant davegallant changed the title Add enableSyntaxHighlighting option to zsh zsh: add enableSyntaxHighlighting option Jun 27, 2021
@sumnerevans
Copy link
Member

Thanks for the contribution! I have been using zsh-fast-syntax-highlighting (not sure the difference, really). I wonder if it's worth allowing the package to be configurable?

@davegallant
Copy link
Contributor Author

Thanks for the contribution! I have been using zsh-fast-syntax-highlighting (not sure the difference, really). I wonder if it's worth allowing the package to be configurable?

👍 I've attempted to make this configurable through highlighters set. There might be a more nix way to do this though.

@davegallant davegallant force-pushed the master branch 2 times, most recently from 657ad59 to 99c9076 Compare June 27, 2021 20:15
modules/programs/zsh.nix Outdated Show resolved Hide resolved
@sumnerevans sumnerevans merged commit a17bc32 into nix-community:master Jun 28, 2021
@sumnerevans
Copy link
Member

Thanks for the contribution, @davegallant!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants